-
Notifications
You must be signed in to change notification settings - Fork 37
[FSSDK-11571] Python: Add holdout support and refactor decision logic in DefaultDecisionService #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[FSSDK-11571] Python: Add holdout support and refactor decision logic in DefaultDecisionService #467
Conversation
… in DefaultDecisionService
…o esra/FSSDK-11571_add_holdout_decision_service
|
@esrakartalOpt Problem: For holdout decisions, variation is a dict, not an entities.Variation object. LINE 1234-1238 - CURRENT CODE (WRONG for holdouts)variation_key = ( Why This Fails:
Proof:
Similar Code that properly handles this (lines 1250-1253): Required Fix: Option 1: Handle both dict and objecttry: Option 2: Add check for holdout sourceif flag_decision.source == enums.DecisionSources.HOLDOUT: |
Summary
Test plan
PR checks
Issues